jandres/noVNC
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix Plain authentication test checks

Browse Source 
We should have constants local for the test function when doing
comparisons or we might have false positives because we compare with
buggy values in the code under test.
This commit is contained in:
Pierre Ossman
2023-05-16 15:04:13 +02:00
parent 79f099108f
commit 71bb6f02cd
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/test.rfb.js
View File

@@ -1639,10 +1639,10 @@ describe('Remote Frame Buffer Protocol Client', function () {
clock.tick();
const expectedResponse = [];
push32(expectedResponse, client._rfbCredentials.username.length);
push32(expectedResponse, client._rfbCredentials.password.length);
pushString(expectedResponse, client._rfbCredentials.username);
pushString(expectedResponse, client._rfbCredentials.password);
push32(expectedResponse, 8);
push32(expectedResponse, 8);
pushString(expectedResponse, 'username');
pushString(expectedResponse, 'password');
expect(client._sock).to.have.sent(new Uint8Array(expectedResponse));
sinon.spy(client, "_initMsg");
@@ -1660,10 +1660,10 @@ describe('Remote Frame Buffer Protocol Client', function () {
clock.tick();
const expectedResponse = [];
push32(expectedResponse, client._rfbCredentials.username.length);
push32(expectedResponse, client._rfbCredentials.password.length);
pushString(expectedResponse, client._rfbCredentials.username);
pushString(expectedResponse, client._rfbCredentials.password);
push32(expectedResponse, 8);
push32(expectedResponse, 0);
pushString(expectedResponse, 'username');
pushString(expectedResponse, '');
expect(client._sock).to.have.sent(new Uint8Array(expectedResponse));
sinon.spy(client, "_initMsg");
@@ -1681,10 +1681,10 @@ describe('Remote Frame Buffer Protocol Client', function () {
clock.tick();
const expectedResponse = [];
push32(expectedResponse, client._rfbCredentials.username.length);
push32(expectedResponse, client._rfbCredentials.password.length);
pushString(expectedResponse, client._rfbCredentials.username);
pushString(expectedResponse, client._rfbCredentials.password);
push32(expectedResponse, 300);
push32(expectedResponse, 300);
pushString(expectedResponse, 'a'.repeat(300));
pushString(expectedResponse, 'b'.repeat(300));
expect(client._sock).to.have.sent(new Uint8Array(expectedResponse));
sinon.spy(client, "_initMsg");