fix: remove REDIRECT_URL_KEY from url (#32770)

web/app/account/oauth/authorize/constants.ts

@@ -1,3 +0,0 @@
-export const OAUTH_AUTHORIZE_PENDING_KEY = 'oauth_authorize_pending'
-export const REDIRECT_URL_KEY = 'oauth_redirect_url'
-export const OAUTH_AUTHORIZE_PENDING_TTL = 60 * 3

web/app/account/oauth/authorize/page.tsx

@@ -7,7 +7,6 @@ import {
   RiMailLine,
   RiTranslate2,
 } from '@remixicon/react'
-import dayjs from 'dayjs'
 import { useRouter, useSearchParams } from 'next/navigation'
 import * as React from 'react'
 import { useEffect, useRef } from 'react'
@@ -17,22 +16,10 @@ import Button from '@/app/components/base/button'
 import Loading from '@/app/components/base/loading'
 import Toast from '@/app/components/base/toast'
 import { useLanguage } from '@/app/components/header/account-setting/model-provider-page/hooks'
+import { setPostLoginRedirect } from '@/app/signin/utils/post-login-redirect'
 import { useAppContext } from '@/context/app-context'
 import { useIsLogin } from '@/service/use-common'
 import { useAuthorizeOAuthApp, useOAuthAppInfo } from '@/service/use-oauth'
-import {
-  OAUTH_AUTHORIZE_PENDING_KEY,
-  OAUTH_AUTHORIZE_PENDING_TTL,
-  REDIRECT_URL_KEY,
-} from './constants'
-
-function setItemWithExpiry(key: string, value: string, ttl: number) {
-  const item = {
-    value,
-    expiry: dayjs().add(ttl, 'seconds').unix(),
-  }
-  localStorage.setItem(key, JSON.stringify(item))
-}
 
 function buildReturnUrl(pathname: string, search: string) {
   try {
@@ -86,8 +73,8 @@ export default function OAuthAuthorize() {
   const onLoginSwitchClick = () => {
     try {
       const returnUrl = buildReturnUrl('/account/oauth/authorize', `?client_id=${encodeURIComponent(client_id)}&redirect_uri=${encodeURIComponent(redirect_uri)}`)
-      setItemWithExpiry(OAUTH_AUTHORIZE_PENDING_KEY, returnUrl, OAUTH_AUTHORIZE_PENDING_TTL)
-      router.push(`/signin?${REDIRECT_URL_KEY}=${encodeURIComponent(returnUrl)}`)
+      setPostLoginRedirect(returnUrl)
+      router.push('/signin')
     }
     catch {
       router.push('/signin')

web/app/components/app-initializer.tsx

@@ -84,7 +84,7 @@ export const AppInitializer = ({
           return
         }
 
-        const redirectUrl = resolvePostLoginRedirect(searchParams)
+        const redirectUrl = resolvePostLoginRedirect()
         if (redirectUrl) {
           location.replace(redirectUrl)
           return

web/app/signin/check-code/page.tsx

@@ -57,7 +57,7 @@ export default function CheckCode() {
           router.replace(`/signin/invite-settings?${searchParams.toString()}`)
         }
         else {
-          const redirectUrl = resolvePostLoginRedirect(searchParams)
+          const redirectUrl = resolvePostLoginRedirect()
           router.replace(redirectUrl || '/apps')
         }
       }

web/app/signin/components/mail-and-password-auth.tsx

@@ -78,7 +78,7 @@ export default function MailAndPasswordAuth({ isInvite, isEmailSetup, allowRegis
           router.replace(`/signin/invite-settings?${searchParams.toString()}`)
         }
         else {
-          const redirectUrl = resolvePostLoginRedirect(searchParams)
+          const redirectUrl = resolvePostLoginRedirect()
           router.replace(redirectUrl || '/apps')
         }
       }

web/app/signin/invite-settings/page.tsx

@@ -56,7 +56,7 @@ export default function InviteSettingsPage() {
       if (res.result === 'success') {
         // Tokens are now stored in cookies by the backend
         await setLocaleOnClient(language, false)
-        const redirectUrl = resolvePostLoginRedirect(searchParams)
+        const redirectUrl = resolvePostLoginRedirect()
         router.replace(redirectUrl || '/apps')
       }
     }

web/app/signin/normal-form.tsx

@@ -42,7 +42,7 @@ const NormalForm = () => {
     try {
       if (isLoggedIn) {
         setIsRedirecting(true)
-        const redirectUrl = resolvePostLoginRedirect(searchParams)
+        const redirectUrl = resolvePostLoginRedirect()
         router.replace(redirectUrl || '/apps')
         return
       }

web/app/signin/utils/post-login-redirect.ts

@@ -1,37 +1,15 @@
-import type { ReadonlyURLSearchParams } from 'next/navigation'
-import dayjs from 'dayjs'
-import { OAUTH_AUTHORIZE_PENDING_KEY, REDIRECT_URL_KEY } from '@/app/account/oauth/authorize/constants'
+let postLoginRedirect: string | null = null
 
-function getItemWithExpiry(key: string): string | null {
-  const itemStr = localStorage.getItem(key)
-  if (!itemStr)
-    return null
-
-  try {
-    const item = JSON.parse(itemStr)
-    localStorage.removeItem(key)
-    if (!item?.value)
-      return null
-
-    return dayjs().unix() > item.expiry ? null : item.value
-  }
-  catch {
-    return null
-  }
+export const setPostLoginRedirect = (value: string | null) => {
+  postLoginRedirect = value
 }
 
-export const resolvePostLoginRedirect = (searchParams: ReadonlyURLSearchParams) => {
-  const redirectUrl = searchParams.get(REDIRECT_URL_KEY)
-  if (redirectUrl) {
-    try {
-      localStorage.removeItem(OAUTH_AUTHORIZE_PENDING_KEY)
-      return decodeURIComponent(redirectUrl)
-    }
-    catch (e) {
-      console.error('Failed to decode redirect URL:', e)
-      return redirectUrl
-    }
+export const resolvePostLoginRedirect = () => {
+  if (postLoginRedirect) {
+    const redirectUrl = postLoginRedirect
+    postLoginRedirect = null
+    return redirectUrl
   }
 
-  return getItemWithExpiry(OAUTH_AUTHORIZE_PENDING_KEY)
+  return null
 }