jandres/noVNC
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Stop creating sinon sandbox early

Browse Source 
sinon might not be loaded at this point, which can cause tests to fail.

We could create the sandbox in one of the hooks instead, but let's
remove the sandbox completely to stay consistent with our other tests.
This commit is contained in:
Pierre Ossman
2024-08-05 15:44:07 +02:00
parent 1230a4ce73
commit bc31e4e8a2
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tests/test.webutil.js
View File

@@ -182,16 +182,15 @@ describe('WebUtil', function () {
window.chrome = chrome;
});
const csSandbox = sinon.createSandbox();
beforeEach(function () {
settings = {};
csSandbox.spy(window.chrome.storage.sync, 'set');
csSandbox.spy(window.chrome.storage.sync, 'remove');
sinon.spy(window.chrome.storage.sync, 'set');
sinon.spy(window.chrome.storage.sync, 'remove');
return WebUtil.initSettings();
});
afterEach(function () {
csSandbox.restore();
window.chrome.storage.sync.set.restore();
window.chrome.storage.sync.remove.restore();
});
describe('writeSetting', function () {